egui-winit: Don't consume clipboard shortcuts #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
requested changes
Jan 12, 2024
Dinnerbone
force-pushed
the
consume_keys
branch
from
9875015 to
bdecb2c
Compare
Dinnerbone
changed the title
|
@emilk @Dinnerbone if ui.input_mut(|i| i.events.last() == Some(&Event::Copy))
|| ui.input_mut(|i| i.events.last() == Some(&Event::Cut))
{
}
|
emilk
approved these changes
Jan 17, 2024
emilk
changed the title
|
@rustbasic let's consider what to do there in a separate issue or PR. It feels like a much larger issue. For now I think it makes sense to revert to the old behavior of only considering Copy/Cut/Paste consumed if egui has |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaking change seems to have snuck in during #3649. Previously it would never consume these, today it consumes them unconditionally, and with this change it'll
only consume them if egui wants text inputnever consume them.This is a blocker for updating our application, sadly :(